lkml.org 
[lkml]   [2014]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectPatch Very Minor to loopback.c
From
Very minor patch to loopback.c that I noticed while comparing the
dummy.c code to loopback.c code (dummy.c was based on loopback.c). I
did not see a maintainer in MAINTAINERS in my cursory glance, so I
apologize if this is to the wrong place. I am testing this patch
right now on my laptop and it appears to be working without issues.
It also compiled without warnings.

diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index bb96409..f9f88d7 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -22,6 +22,7 @@
* interface.
* Alexey Kuznetsov: Potential hang under some extreme
* cases removed.
+ * Zachary Winnerman: Extremely minor patch in loopback_xmit
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
@@ -72,7 +73,6 @@ static netdev_tx_t loopback_xmit(struct sk_buff *skb,
struct net_device *dev)
{
struct pcpu_lstats *lb_stats;
- int len;

skb_orphan(skb);

@@ -86,10 +86,9 @@ static netdev_tx_t loopback_xmit(struct sk_buff *skb,
/* it's OK to use per_cpu_ptr() because BHs are off */
lb_stats = this_cpu_ptr(dev->lstats);

- len = skb->len;
if (likely(netif_rx(skb) == NET_RX_SUCCESS)) {
u64_stats_update_begin(&lb_stats->syncp);
- lb_stats->bytes += len;
+ lb_stats->bytes += skb->len;
lb_stats->packets++;
u64_stats_update_end(&lb_stats->syncp);
}

\
 
 \ /
  Last update: 2014-06-12 22:41    [W:0.043 / U:4.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site