Messages in this thread | | | Date | Wed, 11 Jun 2014 23:49:02 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] Input: evdev - Fix incorrect kfree of err_free_client after vzalloc |
| |
On Thu, 12 Jun 2014, Yongtaek Lee wrote:
> This bug was introduced by commit 92eb77d ("Input: evdev - fall back > to vmalloc for client event buffer"). > > vzalloc is used to alloc memory as fallback in case of failure > of kzalloc. But err_free_client was not considered on below case. > 1. kzalloc fail > 2. vzalloc success > 3. evdev_open_device fail > 4. kfree > > So that address checking is needed to call correct free function. > > Signed-off-by: Yongtaek Lee <ytk.lee@samsung.com> > Reviewed-by: Daniel Stone <daniels@collabora.com>
Acked-by: David Rientjes <rientjes@google.com>
| |