lkml.org 
[lkml]   [2014]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[RESEND PATCH] iommu/intel: Exclude devices using RMRRs from IOMMU API domains
From
Date
The user of the IOMMU API domain expects to have full control of
the IOVA space for the domain. RMRRs are fundamentally incompatible
with that idea. We can neither map the RMRR into the IOMMU API
domain, nor can we guarantee that the device won't continue DMA with
the area described by the RMRR as part of the new domain. Therefore
we must prevent such devices from being used by the IOMMU API.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

I didn't see any actionable items from the last posting of this, so
re-posting unchanged.

drivers/iommu/intel-iommu.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index c4f11c0..41db805 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -4171,6 +4171,21 @@ static int intel_iommu_attach_device(struct iommu_domain *domain,
int addr_width;
u8 bus, devfn;

+ /*
+ * With IOMMU API domains we don't have the freedom to insert RMRR
+ * entries into the domain mapping, the IOMMU API user expects full
+ * control of the IOVA space of the device. We also have no ability
+ * to shutdown whatever back channel operations occur through the
+ * RMRR. Therefore our only option is to prevent devices making use
+ * of RMRRs from being used by the IOMMU API. As usual we exempt
+ * USB devices since their RMRR support is largely historical.
+ */
+ if (device_has_rmrr(dev) && (!dev_is_pci(dev) ||
+ (to_pci_dev(dev)->class >> 8) != PCI_CLASS_SERIAL_USB)) {
+ dev_warn(dev, "Device is ineligible for IOMMU domain attach due to platform RMRR requirement. Contact your platform vendor.\n");
+ return -EPERM;
+ }
+
/* normally dev is not mapped */
if (unlikely(domain_context_mapped(dev))) {
struct dmar_domain *old_domain;


\
 
 \ /
  Last update: 2014-06-12 19:21    [W:0.026 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site