lkml.org 
[lkml]   [2014]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call
On Tue, Jun 10, 2014 at 10:48:35PM +0200, Rickard Strandqvist wrote:
> Hi
>
> True!
> Sorry :-(
>
> But then one would either operate strcpy outright.
>
> Or use strlcpy then the code would be:
>
> /* strlcpy() handles not include \0 */
> len = strlcpy(busid, buf + 4, BUSID_SIZE);
>
> /* busid needs to include \0 termination */
> if (!(len < BUSID_SIZE))

I don't like this condition. Just say (len >= BUSID_SIZE). The
comments here are obvious and could be left out.

> return -EINVAL;

I don't have strong feelings about a cleanup patch. But I think that
cppcheck is not being very sofisticated here with the NUL termination
warning so we should not go out of our way to try to silence the
warning.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-06-11 08:21    [W:3.137 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site