lkml.org 
[lkml]   [2014]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of memory' messages
From
Date
On Wed, 2014-06-11 at 10:47 +0300, Dan Carpenter wrote:
> Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> This check introduces 1849 new checkpatch.pl warnings. I looked through
> the first 70 warnings and there were no false positives.

Thanks for checking Dan.

As your systems are much faster than mine, perhaps you could publish
the output of some script like:

$ git ls-files -- "*.[ch]" | while read file ; do \
./scripts/checkpatch.pl -f --emacs --terse --no-summary --types=OOM_MESSAGE $file; \
done

to someplace like kernel janitors.

That might prompt someone to submit patch series for them.

> Besides the bloat issue, I don't like these warnings because they make
> the error handling harder to read. They are sort of a mindless thing
> that people feel they have to do for no particular reason. Since
> people aren't thinking when they write the error message then you get
> NULL dereferences and so on.

Yeah, that too.

cheers, Joe



\
 
 \ /
  Last update: 2014-06-11 18:41    [W:0.113 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site