Messages in this thread Patch in this message |  | | From | Dmitry Kasatkin <> | Subject | [PATCH 4/4] KEYS: validate key trust only with builtin keys | Date | Tue, 10 Jun 2014 11:48:18 +0300 |
| |
This patch allows to specify kernel parameter 'keys_ownerid=builtin' to allow trust validation only using builtin keys.
Signed-off-by: Dmitry Kasatkin <d.kasatkin@samsung.com> --- crypto/asymmetric_keys/x509_public_key.c | 9 +++++++-- include/linux/key.h | 1 + kernel/system_keyring.c | 1 + 3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/crypto/asymmetric_keys/x509_public_key.c b/crypto/asymmetric_keys/x509_public_key.c index d46b790..c3805a8 100644 --- a/crypto/asymmetric_keys/x509_public_key.c +++ b/crypto/asymmetric_keys/x509_public_key.c @@ -24,6 +24,7 @@ #include "public_key.h" #include "x509_parser.h" +static bool builtin_keys; static char *owner_keyid; static int __init default_owner_keyid_set(char *str) { @@ -32,6 +33,8 @@ static int __init default_owner_keyid_set(char *str) if (strncmp(str, "id:", 3) == 0) owner_keyid = str; /* owner local key 'id:xxxxxx' */ + else if (strcmp(str, "builtin") == 0) + builtin_keys = true; return 1; } @@ -197,8 +200,10 @@ static int x509_validate_trust(struct x509_certificate *cert, cert->authority, strlen(cert->authority)); if (!IS_ERR(key)) { - pk = key->payload.data; - ret = x509_check_signature(pk, cert); + if (!builtin_keys || test_bit(KEY_FLAG_BUILTIN, &key->flags)) { + pk = key->payload.data; + ret = x509_check_signature(pk, cert); + } key_put(key); } return ret; diff --git a/include/linux/key.h b/include/linux/key.h index cd0abb8..67c8e7e 100644 --- a/include/linux/key.h +++ b/include/linux/key.h @@ -170,6 +170,7 @@ struct key { #define KEY_FLAG_INVALIDATED 7 /* set if key has been invalidated */ #define KEY_FLAG_TRUSTED 8 /* set if key is trusted */ #define KEY_FLAG_TRUSTED_ONLY 9 /* set if keyring only accepts links to trusted keys */ +#define KEY_FLAG_BUILTIN 10 /* set if key is builtin */ /* the key type and key description string * - the desc is used to match a key against search criteria diff --git a/kernel/system_keyring.c b/kernel/system_keyring.c index 52ebc70..875f64e 100644 --- a/kernel/system_keyring.c +++ b/kernel/system_keyring.c @@ -89,6 +89,7 @@ static __init int load_system_certificate_list(void) pr_err("Problem loading in-kernel X.509 certificate (%ld)\n", PTR_ERR(key)); } else { + set_bit(KEY_FLAG_BUILTIN, &key_ref_to_ptr(key)->flags); pr_notice("Loaded X.509 cert '%s'\n", key_ref_to_ptr(key)->description); key_ref_put(key); -- 1.9.1
|  |