Messages in this thread | | | From | Bjorn Helgaas <> | Date | Tue, 10 Jun 2014 20:23:49 -0600 | Subject | Re: linux-next: build failure after merge of the pci tree |
| |
On Tue, Jun 10, 2014 at 8:02 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi Bjorn, > > After merging the pci tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > > ERROR: ".pci_try_set_mwi" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined! > ERROR: ".pci_clear_mwi" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined! > ERROR: ".pci_try_set_mwi" [drivers/scsi/lpfc/lpfc.ko] undefined! > > Caused by commit 9259d755975f ("PCI: Move EXPORT_SYMBOL so it > immediately follows function/variable"). > arch/powerpc/include/asm/pci.h defines PCI_DISABLE_MWI and there are > two version of those functions depending on the setting of that symbol. > > I have used the pci tree from next-20140610 for today.
Thanks. This is my fault, not Ryan's. I made more similar changes, but didn't notice the #ifdefs around the definitions. I fixed it and will update my "next" branch tomorrow, after Fengguang's buildbot confirms the fix.
Bjorn
| |