lkml.org 
[lkml]   [2014]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] perf/amd: NULL return of kzalloc_node should be handled
From
Thanks Peter for reviewing, and sorry for not think it thoroughly
before submitting.
Is that ok that when amd_uncore_cpu_up_prepare is called from
amd_uncore_cpu_notifier
I return notifier_from_errno(-ENOMEM), and when
amd_uncore_cpu_up_prepare is called from
amd_uncore_init I immediately return -ENODEV?

On Tue, Jun 10, 2014 at 4:22 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Jun 10, 2014 at 03:37:38PM +0800, Zhouyi Zhou wrote:
>
> Less typing more thinking, this is wrong. You should fail when the
> allocation fails.


\
 
 \ /
  Last update: 2014-06-10 11:21    [W:0.389 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site