lkml.org 
[lkml]   [2014]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch V3 7/7] rtmutex: Avoid pointless requeueing in the deadlock detection chain walk
On Tue, 10 Jun 2014, Steven Rostedt wrote:
> On Tue, 10 Jun 2014 19:43:16 +0200 (CEST)
> Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > On Tue, 10 Jun 2014, Steven Rostedt wrote:
> >
> > > On Tue, 10 Jun 2014 09:57:25 -0500
> > > "Brad Mouring" <bmouring@ni.com> wrote:
> > >
> > >
> > > > > + /* Store whether owner is blocked itself and drop locks */
> > > > > + next_lock = task_blocked_on(task);
> > > > task_blocked_on(task) is not clear to me, the recipient of the
> > > > return is the only clue that hints at what the function does.
> > >
> > > Well, this is more than confusing, it's the only user, all other users
> > > are task_blocked_on_lock(), and this causes the code not to compile.
> >
> > Grr, yes.
>
> Luckily you are not posting this to that grumpy IRQ maintainer. He'd
> shoot some frozen sharks your way if you sent him patches like this ;-)

Rightfully so. :)


\
 
 \ /
  Last update: 2014-06-11 01:21    [W:0.067 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site