lkml.org 
[lkml]   [2014]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/2] Add support for Lenovo Compact Keyboard
Date
This patchset follows on from my previous attempt[1] to add support for
these keyboards from Lenovo.

Changes since v1:
* Merge driver into hid-lenovo-tpkbd.c instead of creating our own
driver for the hardware [Jiri Kosina]
* Remove key mappings which are now supported by standard
* Use KEY_FILE for Fn-F12 (opens My Computer on Windows)
* Support the USB variant as well as Bluetooth
* Expose the Fn Lock setting as a sysfs attribute instead of trying to
build a mechanism to toggle into the kernel

I got rid of the Fn-lock toggle code since it didn't play nicely with
the USB keyboard; from what I could ascertain, hid_output_raw_report
wants to sleep when sending a report to a USB keyboard, which isn't
allowed. The same was true when using an input handler.

A sysfs attribute is more flexible anyway, and one could trivially
script a user-space toggling mechanism around it. I suspect in
reality so long as Fn-Lock is left on nobody will really care what the
Fn-Lock key does :)

Applies and tested against 3.14.5.

Cheers,

[1] https://lkml.org/lkml/2014/3/25/535

Jamie Lentin (2):
Loosen seams to allow support of other keyboards
Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

drivers/hid/hid-core.c | 2 +
drivers/hid/hid-ids.h | 2 +
drivers/hid/hid-lenovo-tpkbd.c | 236 +++++++++++++++++++++++++++++++++++++++--
include/linux/hid.h | 1 +
4 files changed, 232 insertions(+), 9 deletions(-)

--
2.0.0.rc2



\
 
 \ /
  Last update: 2014-06-11 01:01    [W:0.081 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site