lkml.org 
[lkml]   [2014]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 059/160] ext4: note the error in ext4_end_bio()
    Date
    3.13.11.3 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Matthew Wilcox <willy@linux.intel.com>

    commit 9503c67c93ed0b95ba62d12d1fd09da6245dbdd6 upstream.

    ext4_end_bio() currently throws away the error that it receives. Chances
    are this is part of a spate of errors, one of which will end up getting
    the error returned to userspace somehow, but we shouldn't take that risk.
    Also print out the errno to aid in debug.

    Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/ext4/page-io.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
    index d488f80..bb621a5 100644
    --- a/fs/ext4/page-io.c
    +++ b/fs/ext4/page-io.c
    @@ -308,13 +308,14 @@ static void ext4_end_bio(struct bio *bio, int error)
    if (error) {
    struct inode *inode = io_end->inode;

    - ext4_warning(inode->i_sb, "I/O error writing to inode %lu "
    + ext4_warning(inode->i_sb, "I/O error %d writing to inode %lu "
    "(offset %llu size %ld starting block %llu)",
    - inode->i_ino,
    + error, inode->i_ino,
    (unsigned long long) io_end->offset,
    (long) io_end->size,
    (unsigned long long)
    bi_sector >> (inode->i_blkbits - 9));
    + mapping_set_error(inode->i_mapping, error);
    }

    if (io_end->flag & EXT4_IO_END_UNWRITTEN) {
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-06-10 23:21    [W:3.306 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site