lkml.org 
[lkml]   [2014]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 160/160] libata: Blacklist queued trim for Crucial M500
    Date
    3.13.11.3 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Martin K. Petersen" <martin.petersen@oracle.com>

    commit 3b8d2676d15d6b2326757adb66b70a9cd6650373 upstream.

    Queued trim only works for some users with MU05 firmware. Revert to
    blacklisting all firmware versions.

    Introduced by commit d121f7d0cbb8 ("libata: Update queued trim blacklist
    for M5x0 drives") which this effectively reverts, while retaining the
    blacklisting of M550.

    See

    https://bugzilla.kernel.org/show_bug.cgi?id=71371

    for reports of trouble with MU05 firmware.

    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Cc: Tejun Heo <tj@kernel.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/ata/libata-core.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
    index 0a79c54..5ab4e3d 100644
    --- a/drivers/ata/libata-core.c
    +++ b/drivers/ata/libata-core.c
    @@ -4224,10 +4224,10 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
    { "PIONEER DVD-RW DVR-216D", NULL, ATA_HORKAGE_NOSETXFER },

    /* devices that don't properly handle queued TRIM commands */
    - { "Micron_M500*", "MU0[1-4]*", ATA_HORKAGE_NO_NCQ_TRIM, },
    - { "Crucial_CT???M500SSD*", "MU0[1-4]*", ATA_HORKAGE_NO_NCQ_TRIM, },
    - { "Micron_M550*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },
    - { "Crucial_CT???M550SSD*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },
    + { "Micron_M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },
    + { "Crucial_CT???M500SSD*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },
    + { "Micron_M550*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },
    + { "Crucial_CT???M550SSD*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },

    /*
    * Some WD SATA-I drives spin up and down erratically when the link
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-06-10 22:41    [W:4.159 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site