Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v3 3/6] ARM: EXYNOS: Remove soc_is_exynos4/5 from exynos.c | Date | Tue, 10 Jun 2014 16:04:47 +0200 |
| |
On Tuesday 10 June 2014 15:55:09 Tomasz Figa wrote: > On 10.05.2014 09:20, Pankaj Dubey wrote: > > This patch removes usage of soc_is_exynos4/5 from exynos.c. > > For this we need to separate machine descriptors for exynos4 > > and exynos5. While doing this patch does some consolidation also. > > > > CC: Russell King <linux@arm.linux.org.uk> > > CC: Thomas Abraham <thomas.abraham@linaro.org> > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > > --- > > arch/arm/mach-exynos/exynos.c | 52 +++++++++++++++++++----------- > > arch/arm/plat-samsung/include/plat/cpu.h | 3 -- > > 2 files changed, 33 insertions(+), 22 deletions(-) > > > > I don't think this is needed. All those static mappings should just go > away, which will also eliminate the need to have separate machine > descriptor or soc_is_exynos{4,5}() macros.
I think I suggested doing this patch as an intermediate step to get rid of the macros first, so we don't get any new users. I agree that we should also remove the static mappings eventually, and once we do that, the machine descriptors can be unified again.
I have not checked which of the map_desc entries are currently used at all, or what it would take to remove them.
Arnd
| |