Messages in this thread Patch in this message | | | From | "Brad Mouring" <> | Date | Tue, 10 Jun 2014 09:10:47 -0500 | Subject | Re: [patch V3 4/7] rtmutex: Siplify remove_waiter() |
| |
On Mon, Jun 09, 2014 at 08:28:08PM -0000, Thomas Gleixner wrote: > Exit right away, when the removed waiter was not the top prioriy > waiter on the lock. Get rid of the extra indent level. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > kernel/locking/rtmutex.c | 26 ++++++++++---------------- > 1 file changed, 10 insertions(+), 16 deletions(-) > > Index: tip/kernel/locking/rtmutex.c > =================================================================== > --- tip.orig/kernel/locking/rtmutex.c > +++ tip/kernel/locking/rtmutex.c > @@ -780,7 +780,7 @@ static void remove_waiter(struct rt_mute > { > int first = (waiter == rt_mutex_top_waiter(lock));
I agree that @first is ambiguous and would prefer something like @is_top_waiter
Reviewed-by: Brad Mouring <brad.mouring@ni.com>
| |