Messages in this thread | | | Date | Tue, 10 Jun 2014 16:30:49 +0530 | From | Kishon Vijay Abraham I <> | Subject | Re: [PATCH 1/4] phy: miphy365x: Add Device Tree bindings for the MiPHY365x |
| |
Hi,
On Thursday 22 May 2014 07:23 PM, Lee Jones wrote: > The MiPHY365x is a Generic PHY which can serve various SATA or PCIe > devices. It has 2 ports which it can use for either; both SATA, both > PCIe or one of each in any configuration.
I've asked others who wrote multi-phy PHY providers to model each individual PHY as sub-node of the PHY provider. So It's only fair I ask you the same to do. So in this case the dt node should look something like:
miphy365x_phy: miphy365x@fe382000 { compatible = "st,miphy365x-phy"; #phy-cells = <2>; st,syscfg = <&syscfg_rear>; channel@0 { reg = <0xfe382000 0x100>, <0xfe394000 0x100>; reg-names = "sata", "pcie"; }
channel@1{ reg = <0xfe38a000 0x100>, <0xfe804000 0x100>; reg-names = "sata", "pcie"; }
};
Thanks Kishon
| |