lkml.org 
[lkml]   [2014]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 14/15] PCI: Remove pci_find_upstream_pcie_bridge()
    From
    Date
    It's broken and has no users.

    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    ---
    drivers/pci/search.c | 35 -----------------------------------
    include/linux/pci.h | 11 -----------
    2 files changed, 46 deletions(-)

    diff --git a/drivers/pci/search.c b/drivers/pci/search.c
    index aea2443..473c6e8 100644
    --- a/drivers/pci/search.c
    +++ b/drivers/pci/search.c
    @@ -244,41 +244,6 @@ struct pci_dev *pci_find_dma_isolation_root(struct pci_dev *pdev)
    return pdev;
    }

    -/*
    - * find the upstream PCIe-to-PCI bridge of a PCI device
    - * if the device is PCIE, return NULL
    - * if the device isn't connected to a PCIe bridge (that is its parent is a
    - * legacy PCI bridge and the bridge is directly connected to bus 0), return its
    - * parent
    - */
    -struct pci_dev *
    -pci_find_upstream_pcie_bridge(struct pci_dev *pdev)
    -{
    - struct pci_dev *tmp = NULL;
    -
    - if (pci_is_pcie(pdev))
    - return NULL;
    - while (1) {
    - if (pci_is_root_bus(pdev->bus))
    - break;
    - pdev = pdev->bus->self;
    - /* a p2p bridge */
    - if (!pci_is_pcie(pdev)) {
    - tmp = pdev;
    - continue;
    - }
    - /* PCI device should connect to a PCIe bridge */
    - if (pci_pcie_type(pdev) != PCI_EXP_TYPE_PCI_BRIDGE) {
    - /* Busted hardware? */
    - WARN_ON_ONCE(1);
    - return NULL;
    - }
    - return pdev;
    - }
    -
    - return tmp;
    -}
    -
    static struct pci_bus *pci_do_find_bus(struct pci_bus *bus, unsigned char busnr)
    {
    struct pci_bus *child;
    diff --git a/include/linux/pci.h b/include/linux/pci.h
    index 5096031..64184d5 100644
    --- a/include/linux/pci.h
    +++ b/include/linux/pci.h
    @@ -1804,15 +1804,4 @@ int pci_for_each_dma_alias(struct pci_dev *pdev,
    u16 alias, void *data), void *data);
    struct pci_dev *pci_find_dma_isolation_root(struct pci_dev *pdev);

    -/**
    - * pci_find_upstream_pcie_bridge - find upstream PCIe-to-PCI bridge of a device
    - * @pdev: the PCI device
    - *
    - * if the device is PCIE, return NULL
    - * if the device isn't connected to a PCIe bridge (that is its parent is a
    - * legacy PCI bridge and the bridge is directly connected to bus 0), return its
    - * parent
    - */
    -struct pci_dev *pci_find_upstream_pcie_bridge(struct pci_dev *pdev);
    -
    #endif /* LINUX_PCI_H */


    \
     
     \ /
      Last update: 2014-05-09 19:21    [W:2.591 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site