Messages in this thread Patch in this message | | | Date | Fri, 09 May 2014 16:54:28 +0200 | From | "Michael Kerrisk (man-pages)" <> | Subject | Re: [PATCH 2/3] sched: Simplify return logic in sched_copy_attr() |
| |
From: Michael Kerrisk <mtk.manpages@gmail.com>
The logic in this function is a little contorted: * Rather than having chained gotos for the -EFBIG case, just return -EFBIG directly. * Now, the label 'out' is no longer needed, and 'ret' must be zero zero by the time we fall through to this point, so just return 0.
Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com> --- kernel/sched/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 6c9ce28..8fa3e12 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -3596,13 +3596,11 @@ static int sched_copy_attr(struct sched_attr __user *uattr, */ attr->sched_nice = clamp(attr->sched_nice, MIN_NICE, MAX_NICE); -out: - return ret; + return 0; err_size: put_user(sizeof(*attr), &uattr->size); - ret = -E2BIG; - goto out; + return -E2BIG; } /** -- 1.9.0
| |