lkml.org 
[lkml]   [2014]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/5] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c
From
2014-05-09 19:42 GMT+09:00, Dan Carpenter <dan.carpenter@oracle.com>:
> On Fri, May 09, 2014 at 07:02:20PM +0900, Daeseok Youn wrote:
>> clean up checkpatch.pl warning:
>> WARNING: please no spaces at the start of a line in
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>> ---
>
>> -#ifdef RLD_TRANS_DEBUGx
>> - if (1 || cxt1e1_log_level >= LOG_MONITOR2)
>> +#ifdef RLD_TRANS_DEBUG
>> + if (1 || cxt1e1_log_level >= LOG_MONITOR2)
>> #else
>
> You fixed a typo here. I don't care about it, because we are going to
> delete this code anyway. But normally I would ask you to redo the patch
> because it should be done separately, and it should be described in the
> changelog instead of slipped in secretly.
Oh.. I didn't know that fixed typo is in this patch. :-)
>
> But in this case, I don't care so you got lucky.
Thanks.

Regards,
Daeseok Youn
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
>


\
 
 \ /
  Last update: 2014-05-09 16:41    [W:0.077 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site