Messages in this thread | | | Date | Thu, 8 May 2014 14:53:08 -0600 | From | Jens Axboe <> | Subject | Re: [PATCH] blk-mq: initialize struct request fields individually |
| |
On 05/06/2014 04:12 AM, Christoph Hellwig wrote: > This allows us to avoid a non-atomic memset over ->atomic_flags as well > as killing lots of duplicate initializations.
I had an earlier variant of this as well, they are quite a few fields we can neglect to initialize. But I think this is a safe start, however, and we can always optimize it on top of it. Perhaps even start to separate struct request a bit, so we can safely memset parts of it easily.
| |