Messages in this thread | | | Date | Thu, 8 May 2014 15:35:36 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH 2/5] cgroup: replace cftype->write_string() with cftype->write() |
| |
On Tue, May 06, 2014 at 08:44:23AM -0400, Tejun Heo wrote: > Convert all cftype->write_string() users to the new cftype->write() > which maps directly to kernfs write operation and has full access to > kernfs and cgroup contexts. The conversions are mostly mechanical. > > * @css and @cft are accessed using of_css() and of_cft() accessors > respectively instead of being specified as arguments. > > * Should return @nbytes on success instead of 0. > > * @buf is not trimmed automatically. Trim if necessary. Note that > blkcg doesn't need this as blkg_conf_prep() can already handle > whitespaces. > > cftype->write_string() has no user left after the conversions and > removed. > > While at it, remove unnecessary local variable @p in > cgroup_subtree_control_write() and stale comment about > CGROUP_LOCAL_BUFFER_SIZE in cgroup_freezer.c. > > This patch doesn't introduce any visible behavior changes. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Vivek Goyal <vgoyal@redhat.com> > Cc: Jens Axboe <axboe@kernel.dk> > Cc: Li Zefan <lizefan@huawei.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Michal Hocko <mhocko@suse.cz> > Cc: Aristeu Rozanski <arozansk@redhat.com> > --- > block/blk-throttle.c | 32 ++++++++++++++++---------------- > block/cfq-iosched.c | 28 ++++++++++++++--------------
Ack to blk-throttle.c and cfq-iosched.c changes.
thanks Vivek
| |