lkml.org 
[lkml]   [2014]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export
    Hi Arnd,

    On 05/08/2014 05:46 PM, Arnd Bergmann wrote:
    > commit 6d48f44b7b2 "mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free"
    > introduced a new function devm_mdiobus_alloc_size() but added an export
    > for a different function devm_mdiobus_alloc(), which was obviously
    > a simple mistake that leads to build error whenever this function is
    > used from a loadable module:
    >
    > ERROR: "devm_mdiobus_alloc_size" [drivers/net/ethernet/ti/davinci_mdio.ko] undefined!

    Sorry for that, and thanks a lot for the fix.

    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > Cc: Grygorii Strashko <grygorii.strashko@ti.com>
    > Cc: Florian Fainelli <f.fainelli@gmail.com>
    > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    > Cc: Lad, Prabhakar <prabhakar.csengg@gmail.com>
    > Cc: David S. Miller <davem@davemloft.net>
    > Cc: netdev@vger.kernel.org
    > ---
    > drivers/net/phy/mdio_bus.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
    > index 68a9a38..a628496 100644
    > --- a/drivers/net/phy/mdio_bus.c
    > +++ b/drivers/net/phy/mdio_bus.c
    > @@ -117,7 +117,7 @@ struct mii_bus *devm_mdiobus_alloc_size(struct device *dev, int sizeof_priv)
    >
    > return bus;
    > }
    > -EXPORT_SYMBOL_GPL(devm_mdiobus_alloc);
    > +EXPORT_SYMBOL_GPL(devm_mdiobus_alloc_size);
    >
    > /**
    > * devm_mdiobus_free - Resource-managed mdiobus_free()
    >

    Regards,
    -grygorii


    \
     
     \ /
      Last update: 2014-05-08 21:21    [W:3.471 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site