lkml.org 
[lkml]   [2014]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] iio:adc: at91 requires the input subsystem
    On 05/08/2014 07:22 PM, Alexandre Belloni wrote:
    > Hi,
    >
    > On 08/05/2014 at 16:56:24 +0200, Arnd Bergmann wrote :
    >> Building the at91 adc driver with CONFIG_INPUT disabled results in this
    >> build error:
    >>
    >> ERROR: "input_event" [drivers/iio/adc/at91_adc.ko] undefined!
    >> ERROR: "input_unregister_device" [drivers/iio/adc/at91_adc.ko] undefined!
    >> ERROR: "input_free_device" [drivers/iio/adc/at91_adc.ko] undefined!
    >> ERROR: "input_register_device" [drivers/iio/adc/at91_adc.ko] undefined!
    >> ERROR: "input_set_abs_params" [drivers/iio/adc/at91_adc.ko] undefined!
    >> ERROR: "input_allocate_device" [drivers/iio/adc/at91_adc.ko] undefined!
    >>
    >> To make sure we can build random configurations, this turns on CONFIG_INPUT
    >> whenever CONFIG_AT91_ADC is enabled.
    >>
    >
    > I'm wondering wether we should make part of the driver compile only if
    > CONFIG_INPUT is defined. Maybe some user will want to use the ADC and
    > not have any input on their board.
    >
    > What do you think ?
    >

    This typically just leads to more build errors. E.g. if INPUT is defined as
    a module, but AT91_ADC is build in. I think it is very rare to see a
    configuration without INPUT set, other then a randconfig.

    - Lars


    \
     
     \ /
      Last update: 2014-05-08 20:21    [W:3.743 / U:0.616 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site