lkml.org 
[lkml]   [2014]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer
From
On Thu, May 8, 2014 at 9:22 AM, David Laight <David.Laight@aculab.com> wrote:
> From: Mathias Nyman
>> From: Dan Williams <dan.j.williams@intel.com>
>>
>> Save someone else the debug cycles of figuring out why a driver's
>> transfer request is failing or causing undefined system behavior.
>> Buffers submitted for dma must come from GFP allocated / DMA-able
>> memory.
>>
>> Return -EAGAIN matching the return value for dma_mapping_error() cases.
>
> Won't that just cause the request to be resubmitted a few clock
> cycles later?
> Surely you either need to error the request, or panic.

No, panic() is too drastic for this.

> In any case is this the right place for this sort of test?

Yes.

The system is already compromised because the driver is broken. The
expectation is that this is a clue bat for a driver developer to fix
their code before it goes upstream. I found this while debugging an
interaction with a new driver that was causing the xhci controller to
lock up. Had this warning been there I likely never would have
received the xhci bug report.


\
 
 \ /
  Last update: 2014-05-08 19:21    [W:0.104 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site