Messages in this thread | | | Date | Thu, 8 May 2014 23:58:02 +0900 | From | Alexandre Courbot <> | Subject | Re: [PATCH] gpio: include linux/bug.h in interface header |
| |
On 05/08/2014 10:42 PM, Arnd Bergmann wrote: > Today's linux-next kernel started showing build errors for the > use of WARN_ON in linux/gpio/consumer.h: > > In file included from drivers/video/backlight/pwm_bl.c:13:0: > include/linux/gpio/consumer.h: In function 'gpiod_put': > include/linux/gpio/consumer.h:81:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration] > > It's not clear why this never happened before, but this patch > fixes it by including the header that contains the defintion > of this macro.
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
I guess this went unnoticed because this part of the code is only active if compiled without gpiolib, which is not a very common configuration. Sorry about that.
> > Signed-off-by: Arnd Bergmann <arnd@arnd.de> > > diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h > index bed128e..073b9b1 100644 > --- a/include/linux/gpio/consumer.h > +++ b/include/linux/gpio/consumer.h > @@ -1,6 +1,7 @@ > #ifndef __LINUX_GPIO_CONSUMER_H > #define __LINUX_GPIO_CONSUMER_H > > +#include <linux/bug.h> > #include <linux/err.h> > #include <linux/kernel.h> > >
| |