Messages in this thread | | | Date | Thu, 8 May 2014 07:55:06 -0500 | Subject | Re: [PATCH 3/4] of/platform: fix device naming for non-translatable addresses | From | Rob Herring <> |
| |
On Thu, May 8, 2014 at 5:41 AM, Arnd Bergmann <arnd@arndb.de> wrote: > On Wednesday 07 May 2014 16:48:17 Rob Herring wrote: >> From: Rob Herring <robh@kernel.org> >> >> Using non-translatable addresses in platform device names is wrong >> because they may not be globally unique. Just use the default naming with >> a global index if the address cannot be translated instead. >> >> of_can_translate_address has the same checks as of_translate_address, so >> we can remove it here as well. > > Have you checked that this doesn't break platforms using clkdev lookup > based on names with local addresses? It's quite possible that nobody > does that, but it would be good to have someone confirm it.
I had not, but now I have. There don't appear to be any cases of that.
Rob
| |