Messages in this thread | | | Date | Thu, 08 May 2014 15:01:48 +0200 | From | Andreas Larsson <> | Subject | Re: [PATCH] usb: gadget: gr_udc: unconditionally use GFP_ATOMIC in gr_queue_ext() |
| |
On 2014-05-07 22:26, Alexey Khoroshilov wrote: > As far as gr_queue() is called with spinlock held, > we have to pass GFP_ATOMIC regardless of gfp argument. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Andreas Larsson <andreas@gaisler.com>
> --- > drivers/usb/gadget/gr_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c > index f984ee75324d..19a1b52c4210 100644 > --- a/drivers/usb/gadget/gr_udc.c > +++ b/drivers/usb/gadget/gr_udc.c > @@ -1679,7 +1679,7 @@ static int gr_queue_ext(struct usb_ep *_ep, struct usb_request *_req, > if (ep->is_in) > gr_dbgprint_request("EXTERN", ep, req); > > - ret = gr_queue(ep, req, gfp_flags); > + ret = gr_queue(ep, req, GFP_ATOMIC); > > spin_unlock(&ep->dev->lock); > >
| |