Messages in this thread | | | Date | Thu, 08 May 2014 17:00:03 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support |
| |
Hello.
On 05/08/2014 12:32 AM, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > The "clocks" entry should be uncommented after the conversion to CCF is > integrated.
> arch/arm/boot/dts/r8a7740.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > index 3834b94dc02a..560d8d71cea4 100644 > --- a/arch/arm/boot/dts/r8a7740.dtsi > +++ b/arch/arm/boot/dts/r8a7740.dtsi > @@ -122,6 +122,19 @@ > 0 149 IRQ_TYPE_LEVEL_HIGH>; > }; > > + ether: ethernet@e9a00000 {
Are you really going to refer to this node somewhere, using its label?
> + compatible = "renesas,gether-r8a7740"; > + reg = <0xe9a00000 0x800>, > + <0xe9a01800 0x800>; > + interrupt-parent = <&gic>; > + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>; > + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */
This property is mandatory, according to the bindings.
WBR, Sergei
| |