lkml.org 
[lkml]   [2014]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/mce: Improve mcheck_init_device() error handling

* Luck, Tony <tony.luck@intel.com> wrote:

> +err_device_create:
> + /*
> + * mce_device_remove behave properly if mce_device_create was not
> + * called on that device.
> + */
> + for_each_possible_cpu(i)
> + mce_device_remove(i);
>
> grammar comment "s/behave/behaves/"
>
> Though perhaps this is better:
>
> /*
> * We didn't keep track of which devices were created above, but
> * even if we had, the set of online cpus might have changed.
> * Play safe and remove for every possible cpu since mce_device_remove()
> * will do the right thing.
> */

and I guess:

s/cpu since/cpu, since/

?

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-05-06 09:01    [W:0.081 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site