Messages in this thread | | | From | Kukjin Kim <> | Subject | RE: [PATCH] provide irq_force_affinity fallback for non-SMP | Date | Tue, 06 May 2014 14:02:20 +0900 |
| |
Arnd Bergmann wrote: > > Patch 01f8fa4f01d "genirq: Allow forcing cpu affinity of interrupts" added > an irq_force_affinity() function, and 30ccf03b4a6 "clocksource: Exynos_mct: > Use irq_force_affinity() in cpu bringup" subsequently uses it. However, > the > driver can be used with CONFIG_SMP disabled, but the function declaration > is only available for CONFIG_SMP, leading to this build error: > > drivers/clocksource/exynos_mct.c:431:3: error: implicit declaration of > function 'irq_force_affinity' [-Werror=implicit-function-declaration] > irq_force_affinity(mct_irqs[MCT_L0_IRQ + cpu], cpumask_of(cpu)); > > This patch introduces a dummy helper function for the non-SMP case > that always returns success, to get rid of the build error. > Since the patches causing the problem are marked for stable backports, > this one should be as well. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Arnd, thanks for your fix the build error.
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
- Kukjin
> Cc: stable@vger.kernel.org > --- > diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h > index 0e6b23f..b72a643 100644 > --- a/include/linux/interrupt.h > +++ b/include/linux/interrupt.h > @@ -272,6 +272,11 @@ static inline int irq_set_affinity(unsigned int irq, > const struct cpumask *m) > return -EINVAL; > } > > +static inline int irq_force_affinity(unsigned int irq, const struct > cpumask *cpumask) > +{ > + return 0; > +} > + > static inline int irq_can_set_affinity(unsigned int irq) > { > return 0;
| |