lkml.org 
[lkml]   [2014]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] Deprecate BUG/BUG_ON in favour of BUG_AND_HALT/BUG_AND_HALT_ON

* Richard Weinberger <richard@nod.at> wrote:

> >> I like the idea but not the name.
> >> What about DIE() and DIE_ON()?
> >
> > CRASH_ON() might be a suggestive name as well, as from the user's
> > point of view we are crashing her system.
>
> I fear such users will think "Why should I crash the kernel?". ;-)

That's exactly the impression that the naming should create in kernel
developers why try to add CRASH_ON() in the future: only do it as an
absolute last resort.

WARN_ON() and other non-destructive ways to deal with error conditions
are almost always preferred.

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-05-06 11:41    [W:0.687 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site