Messages in this thread | | | Date | Sun, 4 May 2014 23:41:17 +0200 | From | Darek Marcinkiewicz <> | Subject | Re: [PATCH v5 1/1] Driver for Beckhoff CX5020 EtherCAT master module. |
| |
On Sun, May 04, 2014 at 11:19:28PM +0200, Francois Romieu wrote: > Darek Marcinkiewicz <reksio@newterm.pl> : > > On Sun, May 04, 2014 at 08:43:51PM +0200, Francois Romieu wrote: > [...] > > > Regarding tx_dnext updates, you may add a short notice in ec_bhf_start_xmit > > > and ec_bhf_process_tx explaining that the periodic poller will somehow end > > > working with the right value, whence no (smp_)barrier at all. > > > > > Hmm, good point. I am not really sure that it is not a race. So, I've added > > memory barriers for the case when the tx ring becomes full. > > Without memory barrier, the hrtimer poller may be wrong but 1) it will > always be pessimistic and 2) it won't last. It would be sloppy though. > > Did you have some time to test the latest version ? > Yes, I have this code continuously running and it looks good. This is a regular application that I have running now, so not all interesting edge cases might have been exercised, though.
-- DM
| |