lkml.org 
[lkml]   [2014]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] arcnet: remove check for CONFIG_SA1100_CT6001
    From
    From: David Miller <davem@davemloft.net>
    Date: Fri, 30 May 2014 17:21:09 -0700 (PDT)

    > From: Paul Bolle <pebolle@tiscali.nl>
    > Date: Tue, 27 May 2014 21:53:44 +0200
    >
    >> A check for CONFIG_SA1100_CT6001 was added in v2.6.11. But the related
    >> Kconfig symbol was never added to the tree. Remove this check and do
    >> some related cleaning up.
    >>
    >> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
    >
    > Applied to net-next, thanks.

    Reverted, you missed more references to BUS_ALIGN in com20020.c:

    drivers/net/arcnet/com20020.c: In function ‘com20020_check’:
    drivers/net/arcnet/com20020.c:120:22: error: ‘BUS_ALIGN’ undeclared (first use in this function)
    drivers/net/arcnet/com20020.c:120:22: note: each undeclared identifier is reported only once for each function it appears in
    drivers/net/arcnet/com20020.c: In function ‘com20020_found’:
    drivers/net/arcnet/com20020.c:182:35: error: ‘BUS_ALIGN’ undeclared (first use in this function)

    For a driver that builds on x86, there is no excuse not to have at least
    build tested this patch.
    \
     
     \ /
      Last update: 2014-05-31 02:41    [W:9.510 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site