lkml.org 
[lkml]   [2014]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch] staging: rtl8723au: fix some confusing indenting
Date
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The break and the "unknown++" are at the same indent level so my static
> checker complains. The if statement should be indented more.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Urgh yes, that should be cleaned up!

Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index eb7b98e..4ad80e7 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
> case WLAN_EID_ERP_INFO:
> case WLAN_EID_EXT_SUPP_RATES:
> case WLAN_EID_VENDOR_SPECIFIC:
> - if (rtw_validate_vendor_specific_ies(pos, elen))
> - unknown++;
> + if (rtw_validate_vendor_specific_ies(pos, elen))
> + unknown++;
> break;
> case WLAN_EID_RSN:
> case WLAN_EID_PWR_CAPABILITY:


\
 
 \ /
  Last update: 2014-05-03 23:21    [W:0.037 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site