Messages in this thread | | | Date | Thu, 29 May 2014 15:44:47 -0500 | Subject | Re: [PATCH] of: treat PCI config space as IORESOURCE_MEM type | From | Rob Herring <> |
| |
On Thu, May 29, 2014 at 11:03 AM, Kumar Gala <galak@codeaurora.org> wrote: > If we have a PCI config space specified in something like a ranges > property we should treat it as memory type resource.
Config space should not be in ranges[1]. We have some cases that are, but we don't want new ones.
> > Signed-off-by: Kumar Gala <galak@codeaurora.org> > --- > drivers/of/address.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/of/address.c b/drivers/of/address.c > index cb4242a..4e7ee59 100644 > --- a/drivers/of/address.c > +++ b/drivers/of/address.c > @@ -122,6 +122,9 @@ static unsigned int of_bus_pci_get_flags(const __be32 *addr) > u32 w = be32_to_cpup(addr); > > switch((w >> 24) & 0x03) { > + case 0x00: /* cfg space */ > + flags |= IORESOURCE_MEM; > + break;
How would you then distinguish actual memory ranges?
Rob
[1] http://www.spinics.net/lists/linux-pci/msg30585.html
| |