lkml.org 
[lkml]   [2014]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: OMAP: SX1: remove check for CONFIG_SX1_OLD_FLASH
On Thu 2014-05-29 12:17:39, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [140529 12:03]:
> > On Fri 2014-05-16 14:12:31, Tony Lindgren wrote:
> > > * Paul Bolle <pebolle@tiscali.nl> [140515 12:42]:
> > > > A check for CONFIG_SX1_OLD_FLASH was added in v2.6.24. But the related
> > > > Kconfig symbol was never part of the tree. So we can remove some dead
> > > > code.
> > >
> > > Thanks applying into omap-for-v3.16/board.
> >
> > Actually... It seems there are two variant of SX1, and this is very
> > useful piece of documentation how the _other_ variant looks.
> >
> > And if someone is hacking linux on sx1, he can probably figure out
> > #ifdef in .c file...
> >
> > IOW adding the config option might be better solution.
>
> Or just a comment saying the same?

Yes, #if 0 with a comment would do the same trick.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-05-29 23:01    [W:0.226 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site