Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 3.12 011/103] sched: declare pid_alive as inline | Date | Thu, 29 May 2014 15:47:56 +0200 |
| |
From: Richard Guy Briggs <rgb@redhat.com>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit 80e0b6e8a001361316a2d62b748fe677ec46b860 upstream.
We accidentally declared pid_alive without any extern/inline connotation. Some platforms were fine with this, some like ia64 and mips were very angry. If the function is inline, the prototype should be inline!
on ia64: include/linux/sched.h:1718: warning: 'pid_alive' declared inline after being called
Signed-off-by: Richard Guy Briggs <rgb@redhat.com> Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- include/linux/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h index 62b89d2f9c01..8594b065d3a8 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1501,7 +1501,7 @@ static inline pid_t task_tgid_vnr(struct task_struct *tsk) } -static int pid_alive(const struct task_struct *p); +static inline int pid_alive(const struct task_struct *p); static inline pid_t task_ppid_nr_ns(const struct task_struct *tsk, struct pid_namespace *ns) { pid_t pid = 0; -- 1.9.3
| |