Messages in this thread | | | Date | Thu, 29 May 2014 15:57:55 +0200 | From | Takashi Iwai <> | Subject | Re: [patch 2/2] ALSA: fireworks: small leak on error path |
| |
At Wed, 28 May 2014 19:42:46 +0300, Dan Carpenter wrote: > > There was a typo here so we return directly instead of freeing "hwinfo". > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
> > diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c > index 8e856cc..996fdc4 100644 > --- a/sound/firewire/fireworks/fireworks.c > +++ b/sound/firewire/fireworks/fireworks.c > @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw) > /* Hardware metering. */ > if (hwinfo->phys_in_grp_count > HWINFO_MAX_CAPS_GROUPS || > hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) { > - return -EIO; > + err = -EIO; > goto end; > } > efw->phys_in = hwinfo->phys_in; >
| |