lkml.org 
[lkml]   [2014]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/4] virtio_ring: unify direct/indirect code paths.
Date
Peter Zijlstra <peterz@infradead.org> writes:
> On Thu, May 29, 2014 at 04:56:45PM +0930, Rusty Russell wrote:
>> Before:
>> gcc 4.8.2: virtio_blk: stack used = 392
>> gcc 4.6.4: virtio_blk: stack used = 480
>>
>> After:
>> gcc 4.8.2: virtio_blk: stack used = 408
>> gcc 4.6.4: virtio_blk: stack used = 432
>
> Is it worth it to make the good compiler worse? People are going to use
> the newer GCC more as time goes on anyhow.

No, but it's only 16 bytes of stack loss for a simplicity win:

virtio_ring.c | 120 +++++++++++++++++++++-------------------------------------
1 file changed, 45 insertions(+), 75 deletions(-)

Cheers,
Rusty.


\
 
 \ /
  Last update: 2014-05-29 14:01    [W:1.565 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site