Messages in this thread | | | Subject | Re: [PATCH 4/4] dt-bindings: mfd: s2mps11: Add support S2MPU02 PMIC | From | Krzysztof Kozlowski <> | Date | Thu, 29 May 2014 10:55:29 +0200 |
| |
On śro, 2014-05-28 at 20:10 +0900, Chanwoo Choi wrote: > This patch add documentation for S2MPU02 PMIC device. S2MPU02 has a little > difference from S2MPS11/S2MPS14 PMIC and has LDO[1-28]/Buck[1-7]. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> > Cc: Kumar Gala <galak@codeaurora.org> > Cc: Randy Dunlap <rdunlap@infradead.org> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Mark Brown <broonie@linaro.org> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: Yadwinder Singh Brar <yadi.brar@samsung.com> > Cc: Tomasz Figa <t.figa@samsung.com> > Cc: Sachin Kamat <sachin.kamat@linaro.org> > Cc: devicetree@vger.kernel.org > Cc: linux-doc@vger.kernel.org > > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-)
Although I'm not a DT maintainer but this looks fine to me, so: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index d81ba30..f7c9180 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -1,5 +1,5 @@ > > -* Samsung S2MPS11 and S2MPS14 Voltage and Current Regulator > +* Samsung S2MPS11, S2MPS14 and S2MPU02 Voltage and Current Regulator > > The Samsung S2MPS11 is a multi-function device which includes voltage and > current regulators, RTC, charger controller and other sub-blocks. It is > @@ -7,7 +7,8 @@ interfaced to the host controller using an I2C interface. Each sub-block is > addressed by the host system using different I2C slave addresses. > > Required properties: > -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps14-pmic". > +- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps14-pmic" > + or "samsung,s2mpu02-pmic". > - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. > > Optional properties: > @@ -81,11 +82,13 @@ as per the datasheet of s2mps11. > - valid values for n are: > - S2MPS11: 1 to 38 > - S2MPS14: 1 to 25 > + - S2MPU02: 1 to 28 > - Example: LDO1, LD02, LDO28 > - BUCKn > - valid values for n are: > - S2MPS11: 1 to 10 > - S2MPS14: 1 to 5 > + - S2MPU02: 1 to 7 > - Example: BUCK1, BUCK2, BUCK9 > > Example:
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |