lkml.org 
[lkml]   [2014]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V4 2/8] opp: call of_node_{get|put}() from of_init_opp_table()
    On 05/27/2014 06:50 AM, Viresh Kumar wrote:
    > All callers of of_init_opp_table() are required to take reference of
    > dev->of_node, by initiating calls to of_node_{get|put}(), before and after
    > calling of_init_opp_table().
    >
    > Its better to call these from within of_init_opp_table(), no fun adding
    > redundant code to every caller.
    >
    > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    > ---
    > drivers/base/power/opp.c | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
    > index faae9cf..2b615b9 100644
    > --- a/drivers/base/power/opp.c
    > +++ b/drivers/base/power/opp.c
    > @@ -622,6 +622,9 @@ int of_init_opp_table(struct device *dev)
    > const __be32 *val;
    > int nr;
    >
    > + if (!of_node_get(dev->of_node))
    > + return -ENODEV;
    > +
    > prop = of_find_property(dev->of_node, "operating-points", NULL);
    > if (!prop)
    > return -ENODEV;
    > @@ -649,6 +652,7 @@ int of_init_opp_table(struct device *dev)
    > nr -= 2;
    > }
    >
    > + of_node_put(dev->of_node);
    > return 0;
    > }
    > EXPORT_SYMBOL_GPL(of_init_opp_table);
    >
    With the same $subject comment as patch #1:
    Acked-by: Nishanth Menon <nm@ti.com>

    --
    Regards,
    Nishanth Menon


    \
     
     \ /
      Last update: 2014-05-30 01:21    [W:2.266 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site