Messages in this thread | | | Subject | Re: [PATCH] misc: genwqe: fix uninitialized return value in genwqe_free_sync_sgl() | From | Frank Haverkamp <> | Date | Wed, 28 May 2014 19:06:32 +0200 |
| |
Hi Christian,
thanks for the contribution to our driver.
Am Dienstag, den 13.05.2014, 22:47 +0200 schrieb Christian Engelmayer: > Function genwqe_free_sync_sgl() returns the value of variable 'rc'. 'rc' is > only set in the error paths, thus initialize it by 0. Coverity CID 1204242. > > Signed-off-by: Christian Engelmayer <cengelma@gmx.at> > --- > Compile tested and applies against branch char-misc-next of tree > git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > --- > drivers/misc/genwqe/card_utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c > index d049d27..5babf40 100644 > --- a/drivers/misc/genwqe/card_utils.c > +++ b/drivers/misc/genwqe/card_utils.c > @@ -454,7 +454,7 @@ int genwqe_setup_sgl(struct genwqe_dev *cd, struct genwqe_sgl *sgl, > */ > int genwqe_free_sync_sgl(struct genwqe_dev *cd, struct genwqe_sgl *sgl) > { > - int rc; > + int rc = 0; > struct pci_dev *pci_dev = cd->pci_dev; > > if (sgl->fpage) {
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
| |