lkml.org 
[lkml]   [2014]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scsi/NCR5380: dprintk macro
On Thu, May 29, 2014 at 12:43:43AM +1000, Finn Thain wrote:
>
> This is the delta between the two submissions:
> [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure
> and
> [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure
>
> The macro definition changes were discussed on the mailing list during
> review. The idea is to get the compiler to check the parameters of
> disabled printk() calls so that the debugging code doesn't rot again.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

Thanks a lot Finn!

> I know the whitespace is wrong throughout these drivers but when I put
> this patch series together it seemed best to defer the whitespace cleanup.
>(I still intend to do that cleanup.)

Yes, I ignored the whitespace warnings in the debug macro cleanups. I
fixed them up for the "newly" added code in the sun3 driver merge.



\
 
 \ /
  Last update: 2014-05-28 18:41    [W:0.030 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site