Messages in this thread | | | Subject | Re: [PATCH] acornscsi: remove linked command support | From | James Bottomley <> | Date | Wed, 28 May 2014 18:26:44 +0400 |
| |
On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: > > The acornscsi driver was added in v2.1.88. It has always #undef-ed > > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be > > sure, it has also always triggered a preprocessor error if > > CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as far as I can see, > > it has never even been possible to set SCSI_ACORNSCSI_LINK through > > kconfig, or its predecessors, in the first place. > > > > Let's remove the code involved. > > > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > And I have to disagree with James here, removing code that isn't even > compiled always is an improvement, especially for an unmaintained > driver.
Well, as I said, this is in theory a maintained driver, so just get an ack from Russell and this debate is moot.
James
| |