lkml.org 
[lkml]   [2014]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 4/7] of: configure the platform device dma parameters
    From
    On Wed, May 28, 2014 at 3:29 PM, Arnd Bergmann <arnd@arndb.de> wrote:
    > On Wednesday 28 May 2014 10:23:09 Linus Walleij wrote:

    >> model = "ARM Integrator/AP";
    >> compatible = "arm,integrator-ap";
    >> + dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
    >>
    >> aliases {
    >> arm,timer-primary = &timer2;
    >>
    >
    > It looks like you accidentally copied the ranges from keystone, even
    > though that has a 64-bit root bus and you only have 32-bit.

    Nah it was no accident, just good old incompetence ;-)

    > I suspect what you want is
    >
    > dma-ranges = <0x80000000 0 0x80000000>;
    >
    > to translate dma_addr_t 0x80000000-0xffffffff to phys_addr_t 0x0-0x7fffffff
    > rather than phys_addr_t 0x800000000-0x87fffffff.

    Thanks, I'll fix up my patch.

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2014-05-28 16:21    [W:4.637 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site