Messages in this thread | | | Date | Wed, 28 May 2014 04:26:28 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] scsi: mpt2sas: mpt2sas_base.c: Fix for possible null pointer dereference |
| |
> - ioc_status = le16_to_cpu(mpi_reply->IOCStatus) & MPI2_IOCSTATUS_MASK; > + if (mpi_reply) { > + ioc_status = le16_to_cpu(mpi_reply->IOCStatus) & MPI2_IOCSTATUS_MASK; > + } > > if (ioc_status != MPI2_IOCSTATUS_SUCCESS) > ioc->port_enable_failed = 1;
ioc_status isn't initialized without the reply and used here as well as later in the function. I think we'll need input from LSI or others with the spec on what to do when we didn't get a reply.
| |