lkml.org 
[lkml]   [2014]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pwm: i.MX: Cleanup indentation for register definitions
Hi,

Liu Ying wrote:
> This patch contains no logic change to cleanup indentation
> for register definitions only.
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawn.guo@freescale.com>
> Cc: Lothar Waßmann <LW@KARO-electronics.de>
> Cc: linux-pwm@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> drivers/pwm/pwm-imx.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index cc47733..0784554 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -21,24 +21,24 @@
>
> /* i.MX1 and i.MX21 share the same PWM function block: */
>
> -#define MX1_PWMC 0x00 /* PWM Control Register */
> -#define MX1_PWMS 0x04 /* PWM Sample Register */
> -#define MX1_PWMP 0x08 /* PWM Period Register */
> +#define MX1_PWMC 0x00 /* PWM Control Register */
> +#define MX1_PWMS 0x04 /* PWM Sample Register */
> +#define MX1_PWMP 0x08 /* PWM Period Register */
>
> -#define MX1_PWMC_EN (1 << 4)
> +#define MX1_PWMC_EN (1 << 4)
>
> /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */
>
> -#define MX3_PWMCR 0x00 /* PWM Control Register */
> -#define MX3_PWMSAR 0x0C /* PWM Sample Register */
> -#define MX3_PWMPR 0x10 /* PWM Period Register */
> -#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4)
> -#define MX3_PWMCR_DOZEEN (1 << 24)
> -#define MX3_PWMCR_WAITEN (1 << 23)
> +#define MX3_PWMCR 0x00 /* PWM Control Register */
> +#define MX3_PWMSAR 0x0C /* PWM Sample Register */
> +#define MX3_PWMPR 0x10 /* PWM Period Register */
> +#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4)
^
You could also add the missing () around the macro argument when you
are changing this line anyway.


Lothar Waßmann
--
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-05-28 14:01    [W:0.070 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site