Messages in this thread | | | From | Andy Lutomirski <> | Date | Mon, 26 May 2014 10:59:33 -0700 | Subject | Re: [PATCH] x86, MCE: Flesh out when to panic comment |
| |
On Mon, May 26, 2014 at 10:51 AM, Borislav Petkov <bp@alien8.de> wrote: > On Mon, May 26, 2014 at 09:47:38AM -0700, Andy Lutomirski wrote: >> It may be worth at least pointing out that mce_severity looks at >> whether we faulted from kernel context. I missed that the first time >> around because mce_severity doesn't take a pt_regs pointer. > > Right, but next time we talk about a different aspect which isn't > commented on in the handler, we'd have to add to it again, until we've > rewritten the whole function in pseudo code. > > I think simply pointing to the function which decides the fate of the > machine based on the MCE severity is enough - people can then go and > stare at it, albeit with some struggle.
Fair enough.
> > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > --
-- Andy Lutomirski AMA Capital Management, LLC
| |