Messages in this thread | | | Date | Mon, 26 May 2014 19:49:17 +0200 | From | Willy Tarreau <> | Subject | Re: [PATCH 1/3] staging: panel: (coding style) Matching braces |
| |
On Mon, May 26, 2014 at 10:28:10AM -0700, Joe Perches wrote: > On Mon, 2014-05-26 at 16:28 +0200, Willy Tarreau wrote: > > I believe that most of the kernel code prefers the two-line format resluting > > in this instead : > > > > } > > else if (*esc >= 'A' && *esc <= 'Z') { > > value |= (*esc - 'A' + 10) << shift; > > } > > else if (*esc >= 'a' && *esc <= 'z') { > > value |= (*esc - 'a' + 10) << shift; > > } > > else { > > grep shows what kernel style is most used. > > Your form: > } > else if (...) { > > (This shows 3 lines per instance) > $ grep-2.5.4 -rP --include=*.[ch] '}\n[ \t]*else if.*{\n' * | wc -l > 909 > > Generally used form: > } else if (...) { > > (mostly shows 2 lines per instance) > $ grep-2.5.4 -rP --include=*.[ch] '} else if.*{\n' * | wc -l > 31653 > > That's ~50:1 preference for "} else if (...) {"
Ah indeed, I wouldn't have thought that. Thanks for correcting me, Joe!
Willy
| |