Messages in this thread | | | Subject | Re: [PATCH] cpufreq: s5pv210: remove unused call of pr_err() | From | Paul Bolle <> | Date | Thu, 22 May 2014 08:41:34 +0200 |
| |
Sachin,
On Thu, 2014-05-22 at 08:52 +0530, Sachin Kamat wrote: > The config symbol itself is not defined and hence could be removed. > However I feel, the > error message could be retained after trimming down the arguments a bit.
My reasoning is, of course, that never used code can simply be dropped.
But you want to print an error here. That's fine with me. I prefer if you'd submit a patch that does that, as I have no idea whatsoever why an error is needed here nor what that error should say.
I do hope you don't mind me prodding you if that takes too long, and this pointless check of CONFIG_PM_VERBOSE is still here after, say, another development cycle.
Paul Bolle
| |