Messages in this thread | | | Date | Thu, 22 May 2014 13:54:23 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages |
| |
On 05/22/2014 06:55 AM, Jingoo Han wrote: > On Monday, May 19, 2014 7:48 PM, Daniel Lezcano wrote: >> On 04/29/2014 10:26 AM, Jingoo Han wrote: >>> The site-specific OOM messages are unnecessary, because they >>> duplicate the MM subsystem generic OOM message. >> >> Are you sure the MM subsys display a message when an allocation fails ? >> >> There are multiple reasons an allocation can fail. > > (+cc Viresh Kumar, Laurent Pinchart, Dan Carpenter, Joe Perches, > Thierry Reding, Andrew Morton) > > There was a discussion about this in other threads. [1] > Please refer to the following link. Thank you. > > [1] http://patchwork.ozlabs.org/patch/324158/
Ok, thanks for the pointer.
>>> Signed-off-by: Jingoo Han <jg1.han@samsung.com> >>> --- >>> drivers/clocksource/em_sti.c | 4 +--- >>> 1 file changed, 1 insertion(+), 3 deletions(-) >>> >>> diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c >>> index 9d17083..d0a7bd6 100644 >>> --- a/drivers/clocksource/em_sti.c >>> +++ b/drivers/clocksource/em_sti.c >>> @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev) >>> int irq; >>> >>> p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL); >>> - if (p == NULL) { >>> - dev_err(&pdev->dev, "failed to allocate driver data\n"); >>> + if (p == NULL) >>> return -ENOMEM; >>> - } >>> >>> p->pdev = pdev; >>> platform_set_drvdata(pdev, p); >>> >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |